pre-commit upgrade codespell and fix spelling #10144
Conversation
boring-cyborg
bot
added
component:api
component:integration-test
component:kvm
component:simulator
component:storage
component:vmware
component:XenServer
Python
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10144 +/- ##
=========================================
Coverage 16.06% 16.06%
- Complexity 12871 12872 +1
=========================================
Files 5642 5642
Lines 493973 493973
Branches 59895 59895
=========================================
+ Hits 79348 79351 +3
+ Misses 405839 405837 -2
+ Partials 8786 8785 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11930 |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11939 |
| @@ -35,6 +35,7 @@ aqcuire | |||
| aqcuired | |||
| aquire | |||
| aquiring | |||
| assertin | |||
There was a problem hiding this comment.
I don't see any usages of assertin, callin, dockin and notin
There was a problem hiding this comment.
I don't see any usages of
assertin,callin,dockinandnotin
The codespell.txt ignored words list is all lowercase but in our codebase it finds both for example:
self.assertIn(f"Failed to allocate
There was a problem hiding this comment.
@jbampton got it. But can you remove fals & ources after fixing those. I can only find 1 instance of these words.
| @@ -211,6 +216,7 @@ faield | |||
| faild | |||
| failes | |||
| falied | |||
| fals | |||
There was a problem hiding this comment.
I can only see one usage of fals which is in plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_ExternalEthernetPort.cs. Better fix in the file and remove fals from here.
| @@ -339,6 +347,7 @@ opeation | |||
| optin | |||
| orginal | |||
| otherwse | |||
| ources | |||
There was a problem hiding this comment.
I can only see one usage of ources which is in plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_EthernetSwitchPort.cs. Better fix in the file and remove ources from here.
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?